Update tests to have less collisions of resources and remove Timecop #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
commented
Dec 13, 2022
| time_travel(time_circuit_half_open) do | ||
| assert_redis_timeout_in_delta(expected_timeout: half_open_resource_timeout) do | ||
| assert_redis_timeout_in_delta(expected_timeout: half_open_resource_timeout) do | ||
| time_travel(time_circuit_half_open) do |
There was a problem hiding this comment.
Changed order, because assert_redis_timeout_in_delta uses Benchmark.measure that uses Process.clock_gettime(Process::CLOCK_MONOTONIC).
miry
force-pushed
the
tests_reformating
branch
from
4cfb84a to
7ca8917
Compare
miry
changed the title
shanempope
approved these changes
Dec 13, 2022
NetHTTP setup method to clean all resources. Update single tests to check resource state. Remove timecop from gemfiles. Disable Minitest/AssertPredicate for linting.
miry
force-pushed
the
tests_reformating
branch
from
5ef968b to
8f800c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetHTTP setup method to clean all resources.
Remove usage of Timecop in redis adapaters.
Update circuite breaker tests to have initialization of resource in multiple lines.