BackgroundHelper: avoid leaking threads #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
approved these changes
Feb 13, 2023
adrianna-chang-shopify
force-pushed
the
avoid-leaking-threads
branch
2 times, most recently
from
25a9030 to
798071a
Compare
casperisfine
force-pushed
the
avoid-leaking-threads
branch
from
798071a to
5990669
Compare
adrianna-chang-shopify
approved these changes
Feb 13, 2023
adrianna-chang-shopify
force-pushed
the
avoid-leaking-threads
branch
from
a06659c to
3f0f1eb
Compare
Many test cases would define `teardown` without calling super so we were never killing threads... It's better to use `before_teardown` anyway, and it's less popular so less likely to be overriden without a super. This is very likely to be the cause of the crash we've seen at https://github.com/Shopify/semian/actions/runs/4122969863/jobs/7120418231 Co-Authored-By: Adrianna Chang <adrianna.chang@shopify.com>
adrianna-chang-shopify
force-pushed
the
avoid-leaking-threads
branch
from
3f0f1eb to
544429f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #471
Many test cases would define
teardownwithout calling super so we were never killing threads...It's better to use
before_teardownanyway, and it's less popular so less likely to be overriden without a super.This is very likely to be the cause of the crash we've seen at https://github.com/Shopify/semian/actions/runs/4122969863/jobs/7120418231
Co-Authored-By: @adrianna-chang-shopify