This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Set OAuth cookies SameSite to lax #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
change_cookies_samesite_to_lax
branch
from
b352999
to
8258a6a
Compare
mkevinosullivan
approved these changes
Feb 9, 2021
NicholasEllul
approved these changes
Feb 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We no longer use 3rd party cookies in any part of apps built using the library, so we don't need to support cross-site requests. That allows us to stop setting our OAuth cookie's
SameSitevalue tonone.WHAT is this pull request doing?
Setting
SameSite=laxin the OAuth cookie.Type of change