Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Include error message into HttpRequestError #1340

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Include error message into HttpRequestError #1340

merged 1 commit into from
Apr 9, 2024

Conversation

5n00p4eg
Copy link
Contributor

@5n00p4eg 5n00p4eg commented Apr 9, 2024

Adding the main error message for the exception from #1330

Related ticket: Shopify/shopify-app-js#764

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md file manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@5n00p4eg 5n00p4eg requested a review from a team as a code owner April 9, 2024 10:16
@5n00p4eg
Copy link
Contributor Author

5n00p4eg commented Apr 9, 2024

@paulomarg One more please

paulomarg
paulomarg approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow good catch, I missed that :)

@paulomarg paulomarg merged commit 4305620 into Shopify:main Apr 9, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5n00p4eg @paulomarg