Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Add isActive() session method #153

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add isActive() session method #153

merged 1 commit into from
Apr 29, 2021

Conversation

carmelal
Copy link
Contributor

@carmelal carmelal commented Mar 30, 2021

Why are these changes introduced?

What is this pull request doing?

  • Adds method checking if a session is active
  • Adds SessionInterface type to use instead of Session
  • Moves session storage tests to correct directory level
  • Layers auth exports

Type of change

  • Minor: New feature (non-breaking change which adds functionality)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@carmelal carmelal force-pushed the method-check-session-active branch 2 times, most recently from a9ad33b to 6726dca Compare March 30, 2021 21:06
@paulomarg
Copy link
Contributor

This is looking great! While we're at it, we should also export the SessionInterface type since that's what apps will need to implement their custom session storages with types. We should also update the docs once it's done to reflect that.

@carmelal carmelal force-pushed the method-check-session-active branch 2 times, most recently from 4714497 to 5c8d7bc Compare April 1, 2021 19:00
@carmelal carmelal marked this pull request as ready for review April 1, 2021 19:01
@carmelal carmelal requested a review from a team as a code owner April 1, 2021 19:01
CHANGELOG.md Outdated Show resolved Hide resolved
@carmelal carmelal force-pushed the method-check-session-active branch from 5c8d7bc to 0b7e5ea Compare April 6, 2021 14:18
@carmelal carmelal changed the title [WIP] Add isActive() session method Add isActive() session method Apr 6, 2021
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm happy for this to go in after we deal with my comment.

src/auth/session/index.ts Outdated Show resolved Hide resolved
@carmelal carmelal force-pushed the method-check-session-active branch from 0b7e5ea to a889da5 Compare April 8, 2021 17:33
@carmelal carmelal changed the title Add isActive() session method [WIP] Add isActive() session method Apr 9, 2021
@carmelal carmelal marked this pull request as draft April 9, 2021 16:49
@carmelal carmelal changed the title [WIP] Add isActive() session method Add isActive() session method Apr 9, 2021
@carmelal carmelal marked this pull request as ready for review April 9, 2021 18:30
@carmelal carmelal force-pushed the method-check-session-active branch from a889da5 to 597c870 Compare April 20, 2021 14:39
src/auth/session/session.ts Outdated Show resolved Hide resolved
src/auth/session/storage/custom.ts Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thecodepixi thecodepixi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I think you just need to move your changelog note up a bit, but otherwise approved!

@carmelal carmelal force-pushed the method-check-session-active branch from 2ece6e3 to 36a24e2 Compare April 29, 2021 14:07
@carmelal carmelal merged commit 9161b47 into main Apr 29, 2021
@carmelal carmelal deleted the method-check-session-active branch April 29, 2021 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port verifyToken from koa-shopify-auth
4 participants