This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmelal
force-pushed
the
method-check-session-active
branch
2 times, most recently
from
March 30, 2021 21:06
a9ad33b
to
6726dca
Compare
This is looking great! While we're at it, we should also export the |
carmelal
force-pushed
the
method-check-session-active
branch
2 times, most recently
from
April 1, 2021 19:00
4714497
to
5c8d7bc
Compare
thecodepixi
reviewed
Apr 5, 2021
thecodepixi
reviewed
Apr 5, 2021
carmelal
force-pushed
the
method-check-session-active
branch
from
April 6, 2021 14:18
5c8d7bc
to
0b7e5ea
Compare
carmelal
changed the title
[WIP] Add isActive() session method
Add isActive() session method
Apr 6, 2021
paulomarg
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm happy for this to go in after we deal with my comment.
carmelal
force-pushed
the
method-check-session-active
branch
from
April 8, 2021 17:33
0b7e5ea
to
a889da5
Compare
carmelal
changed the title
Add isActive() session method
[WIP] Add isActive() session method
Apr 9, 2021
carmelal
changed the title
[WIP] Add isActive() session method
Add isActive() session method
Apr 9, 2021
carmelal
force-pushed
the
method-check-session-active
branch
from
April 20, 2021 14:39
a889da5
to
597c870
Compare
carmelal
force-pushed
the
method-check-session-active
branch
from
April 23, 2021 16:05
597c870
to
2ece6e3
Compare
thecodepixi
reviewed
Apr 29, 2021
thecodepixi
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I think you just need to move your changelog
note up a bit, but otherwise approved!
carmelal
force-pushed
the
method-check-session-active
branch
from
April 29, 2021 14:07
2ece6e3
to
36a24e2
Compare
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
What is this pull request doing?
SessionInterface
type to use instead ofSession
auth
exportsType of change
Checklist