Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Fix jwt not active error by adding a small clock tolerence #227

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Fix jwt not active error by adding a small clock tolerence #227

merged 2 commits into from
Oct 26, 2021

Conversation

tolgap
Copy link
Contributor

@tolgap tolgap commented Aug 1, 2021

WHY are these changes introduced?

Fixes #207

auth0/node-jsonwebtoken supports a clockTolerance option for small differences between machines on the internet. There are multiple users complaining about running into jwt not active errors.

WHAT is this pull request doing?

Uses the clockTolerance option from auth0/node-jsonwebtoken. Sets it at a respectable 5 seconds. All my issues where small differences from 4 seconds to 2 seconds.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@tolgap tolgap requested a review from a team as a code owner August 1, 2021 15:10
@ghost ghost added the cla-needed label Aug 1, 2021
@devopsangel
Copy link

Any updates on this? This seems a blocker to move to latest shopify pkgs.

"@shopify/app-bridge-react": "^2.0.3",
        "@shopify/app-bridge-utils": "^2.0.3",
        "@shopify/koa-shopify-auth": "^4.1.4",
        "@shopify/koa-shopify-graphql-proxy": "^5.0.2",
        "@shopify/koa-shopify-webhooks": "^3.0.2",
        "@shopify/react-shopify-app-route-propagator": "^3.0.8",
        "@shopify/polaris": "^6.6.0",
        "@shopify/polaris-icons": "^4.6.2",
        "@shopify/shopify-api": "^1.4.1",

@mllemango mllemango changed the base branch from main to v2 October 26, 2021 19:22
@ghost ghost removed the cla-needed label Oct 26, 2021
@mllemango
Copy link
Contributor

Thanks for fixing this! We’re packaging this into our v2 branch for release soon 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadCurrentSession fails with error "jwt not active". Add support for clockTolerance when verifying JWTs.
3 participants