Expand objects in HTTP request error messages #252

paulomarg · 2021-10-22T17:26:51Z

Fixes #220
Fixes #237
Fixes #250

We can sometimes receive error messages that are not strings, and we were not printing them properly before.

Printing the error messages as JSON so that we can handle any type of error.

Type of change

Patch: Bug (non-breaking change which fixes an issue)
Minor: New feature (non-breaking change which adds functionality)
Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

I have added a changelog entry, prefixed by the type of change noted above
I have added/updated tests for this change
I have documented new APIs/updated the documentation for modified APIs (for public APIs)

paulomarg requested a review from mllemango October 22, 2021 17:26

paulomarg requested a review from a team as a code owner October 22, 2021 17:26

Expand objects in HTTP request error messages

f724478

paulomarg force-pushed the fix_object_error_messages branch from cddbc80 to f724478 Compare October 22, 2021 17:28

mllemango approved these changes Oct 22, 2021

View reviewed changes

paulomarg merged commit c9d9451 into main Oct 22, 2021

paulomarg deleted the fix_object_error_messages branch October 22, 2021 17:31

shopify-shipit bot temporarily deployed to production October 22, 2021 17:36 Inactive

shopify-shipit bot had a problem deploying to next March 8, 2022 22:12 Failure

shopify-shipit bot temporarily deployed to next March 8, 2022 22:13 Inactive