This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Stop sending request response from the GraphQL proxy #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
paulo/stop_returning_on_gql_proxy
branch
3 times, most recently
from
b8a63ce
to
22ca050
Compare
JaKXz
approved these changes
Mar 2, 2022
Co-authored-by: Jason Kurian <jason.kurian@shopify.com>
paulomarg
force-pushed
the
paulo/stop_returning_on_gql_proxy
branch
from
22ca050
to
08d881c
Compare
|
This seems to be a breaking change. But what actually breaks? The changelog doesn't mention what to do to if you upgrade. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We noticed that the way the GraphQL proxy currently works is inconsistent with how the webhook
processmethod works - while the webhook method returned the result of its operation, the proxy was triggering the actual response to be sent to the client, which was quite confusing.WHAT is this pull request doing?
Changing the GraphQL proxy so it behaves consistently by returning the response of the queried request to the app, rather than taking over and responding to the request itself.
This allows apps to take the body of a proxied request and 1) respond however they prefer; 2) run any code they need to after sending the request.
Type of change
Checklist