This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Store state instead of session id in cookie #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevinosullivan
force-pushed
the
kos/save_state_to_cookie
branch
from
67333a8
to
962a773
Compare
paulomarg
reviewed
Jul 29, 2022
src/auth/oauth/oauth.ts
Outdated
| } | ||
|
|
||
| cookies.set(ShopifyOAuth.SESSION_COOKIE_NAME, currentSession.id, { | ||
| cookies.set(ShopifyOAuth.SESSION_COOKIE_NAME, session.id, { |
There was a problem hiding this comment.
I can't tell from the diff, but is this only run when not embedded? We shouldn't even need to set the session in the cookie if it's embedded, right?
There was a problem hiding this comment.
It's run regardless of embedded/not-embedded ... which is the same as it does today.
There was a problem hiding this comment.
Technically, we could just NOT run this if Context.IS_EMBEDDED_APP, right? Right now we're just creating a cookie that expires immediately, so it doesn't really add value.
Rather than create a temporary session in order to store a session id in a cookie for the initial OAuth transaction, we can store the state that can be compared against the state provided by Shopify in the callback, and then create the session at that point instead. Fixes Shopify/first-party-library-planning#388
mkevinosullivan
force-pushed
the
kos/save_state_to_cookie
branch
from
0bc2390
to
991b937
Compare
mkevinosullivan
commented
Aug 18, 2022
paulomarg
approved these changes
Aug 18, 2022
src/auth/oauth/oauth.ts
Outdated
| } | ||
|
|
||
| cookies.set(ShopifyOAuth.SESSION_COOKIE_NAME, currentSession.id, { | ||
| cookies.set(ShopifyOAuth.SESSION_COOKIE_NAME, session.id, { |
There was a problem hiding this comment.
Technically, we could just NOT run this if Context.IS_EMBEDDED_APP, right? Right now we're just creating a cookie that expires immediately, so it doesn't really add value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently, when an app calls
beginAuthwe create a temporary session and store the session id in the cookie that will be passed throughout the OAuth process. InvalidateAuthCallback, we use the session id from the cookie to retrieve thestatevalue, which we then compare to thestatevalue we received from Shopify as part of the validation.Fixes https://github.com/Shopify/first-party-library-planning/issues/388
WHAT is this pull request doing?
Rather than create a temporary session in order to store a session id in a cookie for the OAuth transaction, we can store the state in the cookie instead, that can be compared against the state provided by Shopify in the callback, and then create the session at that point.
Type of change
Checklist