This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Fix sanitizeHost validation #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
fix_sanitize_host
branch
from
739c8f9
to
eb2fabf
Compare
paulomarg
force-pushed
the
fix_sanitize_host
branch
from
eb2fabf
to
95935c8
Compare
mkevinosullivan
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There are some cases where the
sanitizeHostfunction doesn't accepthosts generated by Shopify, which seem to lack the padding=s at the end.WHAT is this pull request doing?
Making the regexp for validating hosts more flexible by making the
=signs optional.Type of change
Checklist