This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Log translated webhook topic when not found #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
log_graphql_topic_in_webhook_errors
branch
from
82cfa99
to
e13713c
Compare
cquemin
reviewed
Dec 7, 2022
mkevinosullivan
approved these changes
Dec 13, 2022
paulomarg
force-pushed
the
log_graphql_topic_in_webhook_errors
branch
from
e13713c
to
eb676b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of #625
Currently, we're using
topicwhen throwing an error because a webhook handler was not found. While it isn't incorrect, we should be usinggraphqlTopicto show thePRODUCTS_UPDATEformat rather thanproducts/update, so that the error isn't misleading for callers.WHAT is this pull request doing?
Changing the variable we use for the error message to make the message consistent with the configuration.
Type of change
Checklist