This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Don't ignore previous headers when beginning OAuth #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #651
As pointed out in the issue, there is currently no way of adding custom headers to a response when beginning OAuth on Node.js environments, because we overwrite all headers with the ones we need to set. We need to preserve any headers previously set by the app when adding our own.
WHAT is this pull request doing?
Changing the oauth begin process to start out from the incoming response via a new conversion method (defaulting to an empty one for non-node environments), and then adding our cookies / redirect headers on top of those rather ignoring all of them.
Type of change
Checklist