This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Clone the JWT session before overriding the expiration #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodepixi
approved these changes
Jan 14, 2021
mkevinosullivan
approved these changes
Jan 14, 2021
paulomarg
force-pushed
the
fix_session_expiration_again
branch
from
b6f2180
to
3032958
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
My previous fix was faulty in that it was overriding the expiration of the OAuth session before cloning it, which meant that the JWT session was also expiring right away.
WHAT is this pull request doing?
Cloning the JWT session prior to overwriting the expiration of the cookie one, so the expiration date is preserved.
Type of change