This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Separating webhook types into their own file #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
webhook_export_refactorings
branch
from
d75ae00
to
5d3a8ed
Compare
paulomarg
force-pushed
the
webhook_export_refactorings
branch
from
5d3a8ed
to
3b5bed8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The webhooks module was still exporting types in the same file as its implementation file, which made it tricky to surface them outside the library.
WHAT is this pull request doing?
Separates the webhooks types into its own file, which then gets exported alongside the other types in the library.
Type of change