This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Add storefront private token header #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
reviewed
Aug 10, 2023
mllemango
commented
Aug 10, 2023
|
|
||
| if (this.storefrontAccessToken && privateToken) { | ||
| logger(this.storefrontClass().config).warning( | ||
| 'You have both private and public storefront access tokens. The private token will be used.', |
There was a problem hiding this comment.
Logging here instead of earlier at validateConfig because the config params doesn't include the public access token at that point. I could do a blanket log.info at the earlier stage but I feel like that's a little bit spammy
There was a problem hiding this comment.
I agree - this shouldn't be a super common case but it's nice to nudge folks to fix it!
mllemango
changed the title
paulomarg
approved these changes
Aug 10, 2023
|
|
||
| if (this.storefrontAccessToken && privateToken) { | ||
| logger(this.storefrontClass().config).warning( | ||
| 'You have both private and public storefront access tokens. The private token will be used.', |
There was a problem hiding this comment.
I agree - this shouldn't be a super common case but it's nice to nudge folks to fix it!
mllemango
deleted the
revert-961-revert-959-add-storefront-missing-headers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #961
Adding an extra flag to specify the use of the private tokenAdding a warning line to anyone who has both a private and public token
This hopefully avoids any issues that may be caused by the new working private token headers