-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fulfillment orders fulfillment cancellation request #637
Fulfillment orders fulfillment cancellation request #637
Conversation
29f3a21
to
7f5e63c
Compare
1d26023
to
6dae6dd
Compare
6dae6dd
to
e66255e
Compare
7f5e63c
to
90ab4b6
Compare
634d2b3
to
a47cdba
Compare
366a1e8
to
4ce57df
Compare
4ce57df
to
8c5ddaf
Compare
a47cdba
to
1a48c0e
Compare
8c5ddaf
to
41b60d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small change and a couple of nits to keep the tests consistent to the actual API behaviour. Otherwise, looks good!
1a48c0e
to
2bbefa9
Compare
41b60d0
to
f1da843
Compare
2bbefa9
to
741c27e
Compare
f1da843
to
46935ea
Compare
46935ea
to
225ad9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with postman, and sending a JSON body with { "fulfillment_order_line_items": null }
will result in the expected behaviour of not setting the fulfillment_order_line_items
key at all. Likewise with message
.
Great work @karmakaze
741c27e
to
621057d
Compare
225ad9f
to
fc57449
Compare
621057d
to
563d01d
Compare
fc57449
to
c5e8b3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
563d01d
to
eb38d9a
Compare
…ulfillment_request, cancellation_request, accept_cancellation, reject_cancellation to FulfillmentOrder resource
c5e8b3b
to
7247a17
Compare
This PR adds the following POST requests:
POST fulfillment_orders/:fulfillment_order_id/fulfillment_request
POST fulfillment_orders/:fulfillment_order_id/fulfillment_request/accept
POST fulfillment_orders/:fulfillment_order_id/fulfillment_request/reject
POST fulfillment_orders/:fulfillment_order_id/cancellation_request
POST fulfillment_orders/:fulfillment_order_id/cancellation_request/accept
POST fulfillment_orders/:fulfillment_order_id/cancellation_request/reject
GET requests are in PR #633
Actions move, cancel, close for fulfillment orders are in PR #635
Subsequent PRs will add other fulfillment order related POST requests to relevant resources.
Since all that's really needed is the
fulfillment_order_id
, if it's known you can do (rather than querying it first):Note to reviewer:
true
is returned if the request is ok