Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Better handle database failures in session storage adapters #1714

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

andy-liuu
Copy link
Contributor

@andy-liuu andy-liuu commented Oct 31, 2024

TODO:

  • Try it on a real app
  • Add unit tests
    • Ready cases
    • Not ready cases
  • Changeset message for a minor
  • Verify that the typescripting is ok
  • Create an issue to add method to all other session storage implementations and remove prisma's special treatment
  • Make it cleaner
  • Self review

WHY are these changes introduced?

Fixes https://github.com/Shopify/first-party-library-planning/issues/682

WHAT is this pull request doing?

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@andy-liuu andy-liuu self-assigned this Oct 31, 2024
@andy-liuu andy-liuu force-pushed the andy-liuu/add-manual-isready-check-to-prisma-session-storage branch from ee38034 to 2962cb1 Compare November 1, 2024 18:48
@andy-liuu andy-liuu force-pushed the andy-liuu/add-manual-isready-check-to-prisma-session-storage branch from b2c80e2 to af5203e Compare November 5, 2024 17:00
@andy-liuu andy-liuu changed the title [Draft] Fix: Better handle database failures in session storage adapters Fix: Better handle database failures in session storage adapters Nov 5, 2024
@andy-liuu andy-liuu marked this pull request as ready for review November 5, 2024 18:38
@andy-liuu andy-liuu requested a review from a team as a code owner November 5, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant