-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Better handle database failures in session storage adapters #1714
Open
andy-liuu
wants to merge
15
commits into
main
Choose a base branch
from
andy-liuu/add-manual-isready-check-to-prisma-session-storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix: Better handle database failures in session storage adapters #1714
andy-liuu
wants to merge
15
commits into
main
from
andy-liuu/add-manual-isready-check-to-prisma-session-storage
+78
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-liuu
force-pushed
the
andy-liuu/add-manual-isready-check-to-prisma-session-storage
branch
from
November 1, 2024 18:48
ee38034
to
2962cb1
Compare
andy-liuu
force-pushed
the
andy-liuu/add-manual-isready-check-to-prisma-session-storage
branch
from
November 5, 2024 17:00
b2c80e2
to
af5203e
Compare
andy-liuu
changed the title
[Draft] Fix: Better handle database failures in session storage adapters
Fix: Better handle database failures in session storage adapters
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
WHY are these changes introduced?
Fixes https://github.com/Shopify/first-party-library-planning/issues/682
WHAT is this pull request doing?
Type of change
Checklist
pnpm changeset
to create a draft changelog entry (do NOT update theCHANGELOG.md
files manually)