Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Undici to 6.13 #681

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Pin Undici to 6.13 #681

merged 3 commits into from
Apr 24, 2024

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Apr 24, 2024

WHY are these changes introduced?

The @remix-run/node dependency requires undici ^6.10.1, which recently dropped support for Node <18.17 in v6.14.

But the CLI should work with Node > 18.12, so initializing a Remix app with that Node version is currently crashing:

Error coming from `npm install`

Command failed with exit code 1: npm install
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: undici@6.14.1
npm ERR! notsup Not compatible with your version of node/npm: undici@6.14.1
npm ERR! notsup Required: {"node":">=18.17"}
npm ERR! notsup Actual:   {"npm":"8.19.2","node":"v18.12.0"}

WHAT is this pull request doing?

Adds a resolution/override to pin Undici to 6.13.0, which works with Node 18.12.

Test this PR

nvm use 18.12
shopify app init --template https://github.com/Shopify/shopify-app-template-remix#pin-undici 
shopify app init --template https://github.com/Shopify/shopify-app-template-remix#pin-undici --package-manager yarn
shopify app init --template https://github.com/Shopify/shopify-app-template-remix#pin-undici --package-manager pnpm
shopify app init --template https://github.com/Shopify/shopify-app-template-remix#pin-undici --package-manager bun

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 24, 2024 11:13
package.json Outdated Show resolved Hide resolved
@gonzaloriestra gonzaloriestra merged commit 320808b into main Apr 24, 2024
3 checks passed
@gonzaloriestra gonzaloriestra deleted the pin-undici branch April 24, 2024 13:26
paulomarg pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants