Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Remix future flags #891

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Enable Remix future flags #891

merged 9 commits into from
Dec 4, 2024

Conversation

lizkenyon
Copy link
Contributor

WHY are these changes introduced?

This PR enables all of the Remix future flags to opt into all of the changes coming in the next major version.

WHAT is this pull request doing?

Enable v3_fetcherPersist

Enable v3_relativeSplatPath

  • Changes
  • Docs
  • No code changes required, as we don't currently have a splat route with a relative link

Enable v3_throwAbortReason

Enable v3_lazyRouteDiscovery

Enable v3_singleFetch

  • Changes
  • Docs
  • The json helper has been deprecated
  • With this flag turned on though, we can instead return the raw data
  • Update to use the new streamTimout API

Enable v3_routeConfig

  • Changes
  • Docs
  • Adds two new packages to handle the new config base route configuration
  • Adds the new app/routes.ts which is the new standard for defining routes.

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#<your-branch-name>

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@lizkenyon lizkenyon requested a review from a team as a code owner November 26, 2024 19:44
Copy link
Contributor

@matteodepalo matteodepalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is also what I recommended here.

@lizkenyon lizkenyon merged commit 930e14d into main Dec 4, 2024
5 checks passed
@lizkenyon lizkenyon deleted the enable-remix-future-flags branch December 4, 2024 20:30
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants