Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set @remix-run/fs-routes as a dependency to fix Dockerfile build #907

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

sam-b-rose
Copy link
Member

@sam-b-rose sam-b-rose commented Dec 13, 2024

WHY are these changes introduced?

Fixes #906

Docker image build is breaking due to missing the @remix-run/fs-routes package on build.

WHAT is this pull request doing?

Include @remix-run/fs-routes as a dependency in the package.json file to fix the Dockerfile build

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#fix-docker-build

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@sam-b-rose sam-b-rose requested a review from a team as a code owner December 13, 2024 15:44
Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ⭐ !

I will approve this to get this working!
But make an issue for us to look into our docker configuration.

@lizkenyon lizkenyon merged commit 7ad98f6 into main Dec 13, 2024
5 checks passed
@lizkenyon lizkenyon deleted the fix-docker-build branch December 13, 2024 16:24
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
Set `@remix-run/fs-routes` as a dependency to fix Dockerfile build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build Docker container due to dev dependencies in src
2 participants