Abstracting it to a variable to verify if nosec comment applies.

Shopify · Mar 12, 2024 · 385ab37 · 385ab37
1 parent 1453dac
commit 385ab37
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/toxics/toxic.go b/toxics/toxic.go
@@ -81,8 +81,8 @@ func NewToxicStub(input <-chan *stream.StreamChunk, output chan<- *stream.Stream
 func (s *ToxicStub) Run(toxic *ToxicWrapper) {
 	s.running = make(chan struct{})
 	defer close(s.running)
-	// #nosec G404 -- was ignored before too
-	if rand.Float32() < toxic.Toxicity {
+	randomToxicity := rand.Float32() // #nosec G404 -- was ignored before too
+	if randomToxicity < toxic.Toxicity {
 		toxic.Pipe(s)
 	} else {
 		new(NoopToxic).Pipe(s)