-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bail out of the loop when the stub Input stream is done #231
Bail out of the loop when the stub Input stream is done #231
Conversation
Thanks for the fix! < 2MB is definitely a much more reasonable amount of memory usage. I'll take a closer look later tonight and get this merged. |
Ola @xthexder, can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
Can you guys merge this and create a new release? This is pretty important as we cannot simulate network failures for longer periods of time. |
case <-stub.Input: | ||
case c := <-stub.Input: | ||
if c == nil { | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this needs a stub.Close()
.
So I'm pretty sure this is good to merge now. Any chance you can sanity check @xthexder? Unfortunately, our company recently rolled out this contributor license agreement stuff so I can't merge this until the original contributor has clicked through the agreement. @chaosbox I'm so sorry this has taken so long to ship, I'll release this as soon as we merge. |
@jpittis I have accepted the CLA for the emailID tied to my public github account. |
I think you're going to have to change your commit to be authored by the same public email. |
This looks good to me. |
11d4968
to
1390d99
Compare
This PR fixes
Find pprof attached that shows before and after the fix.
Before:
After: