-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate release with Github actions #302
Conversation
2bac280
to
19b6b6e
Compare
19b6b6e
to
68cdc7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit that's safe to ignore.
release: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice - I like how this drops privileges 😍.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires for release to Github.
steps: | ||
- | ||
name: Checkout | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: did you consider using the commit/digest, instead of tracking a mutable tag?
Maybe just for goreleaser/goreleaser-action
? The first party actions/*
actions are less important, but pinning third party actions is a best practice.
I'm a fan of pinning to immutable digests, then using Dependabot to follow v2.3.3
-> v2.3.4
, instead of following the mutable v2
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thank you for the full clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to keep the official actions like actions/checkout@v2
and actions/setup-go@v2
, because there are no maintainers to merge Dependbot's PRs and it was suggested by Github.
The current process according the README is manual. It requires to have access users to DockerHub. After small investigation, found that DockerHub is not actively internaly used and decided to switch container registry to Github. The relase part was done with [goreleaser](https://github.com/goreleaser/goreleaser). It can create Release in Github, Container registries and Homebrew. Update documentation to use Github container registry for new versions.
d173bec
to
e5daf06
Compare
Use Github Container registry instead of DockerHub.