Flags write before arguments in toxiproxy-cli #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #294 introduced a breaking change in client argument parsing. It requires to write [flags before arguments](https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md#flags-before-args). Update help texts and documentation to have POSIX way to use flags and arguments.
miry
force-pushed
the
flags-before-args
branch
from
7d5e10d to
b982a66
Compare
DAmatheson
approved these changes
Sep 3, 2021
Co-authored-by: Drew Matheson <DAmatheson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #294 introduced a breaking change in client argument parsing.
It requires to write flags before arguments.
Update help texts and documentation to have POSIX way to use
flags and arguments.
Example:
Before
After