Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep linux binaries names short #331

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Keep linux binaries names short #331

merged 1 commit into from
Oct 5, 2021

Conversation

miry
Copy link
Contributor

@miry miry commented Oct 4, 2021

Closes #330

Linux packages installs binaries to /usr/local/bin
and has names:

toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64

It is not common way and different from previous releases.

Changes the binary destination path to /usr/bin and has short binary
names:

toxiproxy-server
toxiproxy-cli

Verification:

make

DEB

$ docker run -v $(pwd)/dist:/dist --rm -it ubuntu bash -c "dpkg -i /dist/toxiproxy_*_linux_amd64.deb; ls -1 /usr/bin/toxiproxy-*; /usr/bin/toxiproxy-cli --version"

Preparing to unpack .../toxiproxy_2.1.7_linux_amd64.deb ...
Unpacking toxiproxy (2.1.7) ...
Setting up toxiproxy (2.1.7) ...
/usr/bin/toxiproxy-cli
/usr/bin/toxiproxy-server
toxiproxy-cli version 2.1.7

RPM

$ docker run -v $(pwd)/dist:/dist --rm -it centos bash -c "yum install -y /dist/toxiproxy_*_linux_amd64.rpm; ls -1 /usr/bin/toxiproxy-*; /usr/bin/toxiproxy-cli --version | grep \"toxiproxy-cli version\""
...
Running transaction
  Preparing        :                                                                                                                                                                                                                                                                                                                           1/1 
  Installing       : toxiproxy-2.1.7-1.x86_64                                                                                                                                                                                                                                                                                                  1/1 
  Verifying        : toxiproxy-2.1.7-1.x86_64                                                                                                                                                                                                                                                                                                  1/1 

Installed:
  toxiproxy-2.1.7-1.x86_64                                                                                                                                                                                                                                                                                                                         

Complete!
/usr/bin/toxiproxy-cli
/usr/bin/toxiproxy-server
toxiproxy-cli version 2.1.7

APK

$ docker run -v $(pwd)/dist:/dist --pull always --rm -it alpine sh -c "apk add --allow-untrusted --no-cache /dist/toxiproxy_*_linux_amd64.apk; ls -1 /usr/bin/toxiproxy-*; /usr/bin/toxiproxy-cli --version | grep \"toxiproxy-cli version \""          
latest: Pulling from library/alpine
Digest: sha256:e1c082e3d3c45cccac829840a25941e679c25d438cc8412c2fa221cf1a824e6a
Status: Image is up to date for alpine:latest
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/community/x86_64/APKINDEX.tar.gz
(1/1) Installing toxiproxy (2.1.7)
Executing busybox-1.33.1-r3.trigger
OK: 16 MiB in 15 packages
/usr/bin/toxiproxy-cli
/usr/bin/toxiproxy-server
toxiproxy-cli version 2.1.7

TAR

tar -ztvf dist/toxiproxy_*_linux_amd64.tar.gz                             
-rw-r--r--  0 miry   staff    6388 Oct  4 21:41 CHANGELOG.md
-rw-r--r--  0 miry   staff    1075 Aug 24 08:43 LICENSE
-rw-r--r--  0 miry   staff   19447 Sep 17 22:42 README.md
-rwxr-xr-x  0 miry   staff 4935680 Oct  4 22:07 toxiproxy-server
-rwxr-xr-x  0 miry   staff 6418432 Oct  4 22:07 toxiproxy-cli

@miry miry self-assigned this Oct 4, 2021
@miry miry force-pushed the linux-pkg-bin-names branch from 98bcf72 to 3040cd6 Compare October 4, 2021 19:45
@miry miry changed the title Keep linux binaries short Keep linux binaries names short Oct 4, 2021
@miry miry force-pushed the linux-pkg-bin-names branch from 3040cd6 to 227c454 Compare October 4, 2021 20:08
Closes #330

Linux packages installs binaries to `/usr/local/bin`
and has names:

```
toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64
```

It is not common way and different from previous releases.

Changes the binary destination path to `/usr/bin` and has short binary
names:

```
toxiproxy-server
toxiproxy-cli
```
@miry miry force-pushed the linux-pkg-bin-names branch from 227c454 to 3dafc46 Compare October 5, 2021 09:35
@miry miry merged commit 2f31679 into master Oct 5, 2021
@miry miry deleted the linux-pkg-bin-names branch October 5, 2021 10:49
@miry miry mentioned this pull request Oct 17, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The .deb installer is creating executables with arch info in name
1 participant