Extract common test helpers to own files #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy test file is overused of multiple logics. Make it a bit cleaner, moved `WithTCPServer` to testhelper. Tried to move `WithTCPProxy`, but current structure does not allow it. If move it under package testhelper, it introduces import packages loop. For now extract it to separate helper: `toxiproxy_test.go`. In future it would nice to move business logic code under folder `pkg`.
miry
force-pushed
the
test-restructure
branch
from
1533de3 to
c9920ac
Compare
neufeldtech
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy test file is overused of multiple logics.
Make it a bit cleaner, moved
WithTCPServerto testhelper.Tried to move
WithTCPProxy, but current structure does not allow it.If move it under package testhelper, it introduces import packages loop.
For now extract it to separate helper:
toxiproxy_test.go.First steps to remove dependencies to package
Tomb.In future it would nice to move business logic code under folder
pkg.