Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the server version with command line #353

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

miry
Copy link
Contributor

@miry miry commented Jan 7, 2022

Add flag -version to print the current version and exit.

$ toxiproxy-server -version
toxiproxy-server version v2.3.0

closes: #348

@miry miry self-assigned this Jan 7, 2022
@miry miry force-pushed the server-version-flag branch 2 times, most recently from f522715 to 5887b52 Compare January 7, 2022 13:27
@miry miry marked this pull request as ready for review January 7, 2022 13:27
Copy link
Contributor

@neufeldtech neufeldtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test regarding the Slicer... perhaps it's flaky and not related? CLI change looks fine to me though

--

Update: re-ran and the slicer test passed

Add flag `-version` to print the current version and exit.

```shell
$ toxiproxy-server -version
toxiproxy-server version v2.3.0
```
@miry miry force-pushed the server-version-flag branch from 5887b52 to 51ff1bb Compare January 10, 2022 09:37
@miry miry merged commit c2863c1 into master Jan 10, 2022
@miry miry deleted the server-version-flag branch January 10, 2022 09:45
@miry miry added this to the 2.4.0 milestone Jan 20, 2022
@miry miry added the Toxiproxy label Jan 20, 2022
@miry miry mentioned this pull request Jan 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: please consider adding a -version flag
2 participants