-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release documentation #369
Conversation
Note: When testing these instructions, I came across a problem with the proposed workflow of creating a pull request for updating the release notes and preparing the release... When I did this, because github forced me to do a squash and merge, then there was a mismatch between the commit that landed on master and the tag that I had previously created locally. Options for this workflow are:
@miry when you're back from vacation, let's chat on this some more |
@neufeldtech Thank you for the doc ❤️ |
Hmmm, I might have a flaky test.... === RUN TestProxyMetricsReceivedSentBytes
metrics_test.go:36: expected: [toxiproxy_proxy_received_bytes_total{direction="upstream",listener="localhost:0",proxy="test",upstream="upstream"} 5 toxiproxy_proxy_sent_bytes_total{direction="upstream",listener="localhost:0",proxy="test",upstream="upstream"} 5] got: [] This test was added in my prometheus metrics PR #366 |
Co-authored-by: Michael Nikitochkin <michael.nikitochkin@shopify.com>
attempt to address race condition in tests that happens in CI
Resolves #368