Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string representation of Direction. #430

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Add string representation of Direction. #430

merged 1 commit into from
Sep 6, 2022

Conversation

miry
Copy link
Contributor

@miry miry commented Sep 3, 2022

Allow to print Direction in human form.
Extract Direction struct to a separate file.
Add tests to cover Direction to string.

Add method to detect Direction from string.

@miry miry self-assigned this Sep 3, 2022
@miry miry added the Toxiproxy label Sep 3, 2022
@miry miry marked this pull request as ready for review September 3, 2022 22:58
@miry miry mentioned this pull request Sep 3, 2022
18 tasks
@miry miry added this to the 2.5.0 milestone Sep 3, 2022
@miry miry requested review from a team, frightenedmonkey, yuseinishiyama and dabealu and removed request for a team September 5, 2022 11:58
stream/direction.go Show resolved Hide resolved
Allow to print Direction in human form.
Extract Direction struct to a separate file.
Add tests to cover Direction to string.
Parse direction from string with a new method stream.ParseDirection.
It returns direction or error if could not parse.
@miry miry merged commit 77dfc2f into master Sep 6, 2022
@miry miry deleted the direction-string branch September 6, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants