Use single http client for cli #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
refactoring-client
branch
7 times, most recently
from
7a2d222 to
062467b
Compare
miry
force-pushed
the
refactoring-client
branch
from
003d5dd to
72825a1
Compare
alileza
approved these changes
Sep 14, 2022
alileza
reviewed
Sep 14, 2022
client/client.go
Outdated
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| result, err := io.ReadAll(resp.Body) |
There was a problem hiding this comment.
I wonder if this should be part of send instead, since it's duplicated in 3 other function
There was a problem hiding this comment.
Review from fresh look and moved also request initiazliation inside and remove checking by specific http status code, so now client.go looks even smaller.
alileza
reviewed
Sep 14, 2022
miry
force-pushed
the
refactoring-client
branch
2 times, most recently
from
74e1ba0 to
d178282
Compare
Initialize single http client to request api server. Specify User-Agent and Content-Type. Parse error response in single place.
miry
force-pushed
the
refactoring-client
branch
from
bf379c2 to
48d5c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce single Client httpClient for all cli requests.
It allows to add request headers in single place.
For example adds
User-AgentHTTP header for all requests as"toxiproxy-cli/<version> <os>/<runtime>".Parse response on success or errors.
Set content type as json always.