Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interface of ApiServer.Listen to use addr. #445

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Update interface of ApiServer.Listen to use addr. #445

merged 1 commit into from
Sep 16, 2022

Conversation

miry
Copy link
Contributor

@miry miry commented Sep 15, 2022

Provide addr instead of host and port as separate parameters.

Old:

server.Listen("localhost", "8474")

New:

server.Listen("localhost:8474")

@miry miry self-assigned this Sep 15, 2022
@miry miry added the Toxiproxy label Sep 15, 2022
@miry miry added this to the 2.6.0 milestone Sep 15, 2022
@miry miry mentioned this pull request Sep 15, 2022
Closed
13 tasks
@miry
Update interface of ApiServer.Listen to use addr.
d2ae089 
Provide addr instead of host and port as separate parameters.

Old:
```go
server.Listen("localhost", "8474")
```

New:
```go
server.Listen("localhost:8474")
```
@miry miry marked this pull request as ready for review September 15, 2022 19:37
@miry miry merged commit d2ae089 into master Sep 16, 2022
@miry miry deleted the listen-addr branch September 16, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neufeldtech neufeldtech neufeldtech approved these changes

Assignees

@miry miry

Labels
Toxiproxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miry @neufeldtech