Updated go version to fix 3 CVEs #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able to load rules.
…gci-lint requires list of acceptable packages.
dianadevasia
force-pushed
the
update-go-minor-version
branch
from
d177571 to
9de4395
Compare
dianadevasia
force-pushed
the
update-go-minor-version
branch
from
26ba3e4 to
b7eaa2c
Compare
dianadevasia
commented
Mar 12, 2024
| @@ -23,7 +23,7 @@ jobs: | |||
| - name: golangci-lint | |||
| uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc | |||
| with: | |||
| version: v1.52.2 | |||
| version: v1.56.2 | |||
There was a problem hiding this comment.
the golangci-lint needed to be updated as depguard import rule was enabled and fails without a configuration file - atc0005/go-ci#1024
dianadevasia
commented
Mar 12, 2024
| @@ -21,7 +21,7 @@ func (t *LatencyToxic) delay() time.Duration { | |||
| delay := t.Latency | |||
| jitter := t.Jitter | |||
| if jitter > 0 { | |||
| //#nosec | |||
| // #nosec G404 -- was ignored before too | |||
There was a problem hiding this comment.
Adding the comment in the standard way as mentioned in the documentation.
dianadevasia
commented
Mar 12, 2024
| if t.SizeVariation > 0 { | ||
| mid += rand.Intn(t.SizeVariation*2) - t.SizeVariation | ||
| mid += rand.Intn(t.SizeVariation*2) - t.SizeVariation // #nosec G404 -- was ignored before too |
There was a problem hiding this comment.
golangci-lint was failing so had to add the comment on the same line
dianadevasia
commented
Mar 12, 2024
| @@ -81,8 +81,8 @@ func NewToxicStub(input <-chan *stream.StreamChunk, output chan<- *stream.Stream | |||
| func (s *ToxicStub) Run(toxic *ToxicWrapper) { | |||
| s.running = make(chan struct{}) | |||
| defer close(s.running) | |||
| //#nosec | |||
| if rand.Float32() < toxic.Toxicity { | |||
| randomToxicity := rand.Float32() // #nosec G404 -- was ignored before too | |||
There was a problem hiding this comment.
golangci-lint was failing so had to add the comment on the same line
abecevello
approved these changes
Mar 12, 2024
dianadevasia
force-pushed
the
update-go-minor-version
branch
from
e19a764 to
6ea89cc
Compare
…ded unreleased changelog
dianadevasia
force-pushed
the
update-go-minor-version
branch
from
6ea89cc to
54f1c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue
Will create a release after this PR is merged
References for updating golangci version and depguard changes:
go-critic/go-critic#1359
golangci/golangci-lint#3877
atc0005/go-ci#1024