Bind this.onError for XHR requests in TurboGraft.Remote #119
Conversation
| @@ -33,7 +33,7 @@ class TurboGraft.Remote | |||
| triggerEventFor 'turbograft:remote:start', @initiator, | |||
| xhr: xhr | |||
|
|
|||
| xhr.addEventListener 'error', @onError | |||
| xhr.addEventListener 'error', @onError.bind(@) | |||
|
Looks like it might address a lot of #118 cc @Shopify/tnt |
davidcornu
force-pushed
the
fix-remote-onerror
branch
from
e9949a5
to
56e6fe7
Compare
|
By the looks of things, the |
| @@ -33,7 +33,7 @@ class TurboGraft.Remote | |||
| triggerEventFor 'turbograft:remote:start', @initiator, | |||
| xhr: xhr | |||
|
|
|||
| xhr.addEventListener 'error', @onError | |||
| xhr.addEventListener 'error', @onError.bind(this) | |||
There was a problem hiding this comment.
More CoffeeScript-ey solution is to use => in the method definition (which binds the method in the constructor).
davidcornu
force-pushed
the
fix-remote-onerror
branch
2 times, most recently
from
e0e9fe6
to
e6120ed
Compare
davidcornu
force-pushed
the
fix-remote-onerror
branch
from
e6120ed
to
3fdf980
Compare
| @@ -116,7 +116,7 @@ class TurboGraft.Remote | |||
| enabledInputs.push(input) | |||
| enabledInputs | |||
|
|
|||
| onSuccess: (ev) -> | |||
| onSuccess: (ev) => | |||
There was a problem hiding this comment.
Figured I'd switch this to a fat arrow too seen as it's always used as a callback
|
@qq99 & @lemonmade - round 2 please 😁 |
| httpRequestType: "POST" | ||
| httpUrl: "/foo/bar" | ||
| refreshOnError: "foo" | ||
| fail: done |
There was a problem hiding this comment.
If this never failed, would this test just timeout? Might be worth adding the success case that throws a meaningful error.
|
Just going back to look at dafb3a7#diff-58f1b55d4025fab95951247202574f55L156 to analyze some more... Looks like previously, @davidcornu LGTM let me know when you'd like me to 🎩 this against core |
Yeah that was my conclusion. |
|
@qq99 should be good to go. LMK if you want any help with 🎩 . |
|
Tested it in a few scenarios (order actions, some 422s) and looks good 🎩 |
|
🚢 |
I have a feeling this is causing https://bugsnag.com/shopify/shopify-js/errors/5666f3c78f2356495b6fe53f?filters%5Bevent.since%5D%5B%5D=30d.
r @qq99
cc @arapehl