Fix safari no styles #132
Merged
Fix safari no styles #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -185,6 +185,33 @@ describe 'Turbolinks', -> | |||
| assertLinks(['foo.css']) | |||
| done() | |||
|
|
|||
| it 'many subsequent navigations do not break head asset tracking', (done) -> | |||
There was a problem hiding this comment.
Unless we have a way to run Safari in CI, these don't seem valuable. They probably give a false sense of confidence to the next people who come along and try to update the head query.
There was a problem hiding this comment.
That's fair. I'll wipe them. :)
|
Changes LGTM. Should I 🎩? |
|
Yep, absolutely 🎩 if you can. If you point your repo at |
|
Changes LGTM 👍 |
|
Cool I think this is g2g then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
sometimes the app breakscase where a user navigates several times within a TG application using0.3.0.The breakages were the result of
Turbohead#updatemissing the upstream document's css when processing it. This only occurred randomly (somewhere between 1/10 and 1/20 times) and only on safari. It seems to be the result of:Where the result of extractTrackedAssets would be different than the new implementation:
However, only sometimes, and only on safari. Debugging through or adding
console.logto the loop steps would make the function perform as expected.Since
querySelectordoes not give you a live collection, it seems to be some strange browser level behaviour involving live collections of DOM elements. Similar flakiness was also addressed previously in #93.In addition, there was some concern that we were not testing large numbers of subsequent navigations (though this is not specifically the issue as far as I can tell), so I've included additional tests for this case.