Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes partial replaces inadvertently triggering head asset updates. This was usually not causing issues, but in some cases could break stuff.
I should note that this was partially to blame for the spike in
url.absolute
errors. Submitting a remote form would call:Page.refresh
would then triggerWhich would then try to update the head assets, with an error callback that looked like:
Where
url
is null.Preventing head asset updates on partial request should fix the new instances of this error that all occurred with a
tg-remote
related last event.The old instances of this error are a bit more insidious and will be addressed in an upcoming PR.