-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coffeescript from this library #188
Conversation
Don't force the coffee-rails library as dependencies of applications.
Tests are green and diff of resulting JavaScript doesn't show any big differences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to review up to turbograft/initializers.js
, but I can continue later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any show-stopping issues, so I'll approve. It might be worthwhile to introduce eslint for better formatting in some places as a followup: https://github.com/Shopify/web-configs/tree/19c8d94e5a7703a2f021b746790591adf34dbe3a/packages/eslint-plugin
This repository will probably not evolve further. All code in our apps that use it should at this point be deleted. All code that is kept, should just use Turbo. There is no maintainer for this library, no CI. I'm just doing this migration because I want to remove CoffeeScript from the applications we are using this gem. I don't see need to add eslint, or anything to improve this code further given that. |
if (link.constructor === Link) { | ||
return link; | ||
} | ||
Link.__super__.constructor.call(this, link.href, link); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I figured out that this line needs to be changed to make all the class
syntax to work:
Link.__super__.constructor.call(this, link.href, link); | |
super(link.href, link); |
Otherwise, JS complains that a constructor was not called with new
.
2599cc4
to
553bcfb
Compare
553bcfb
to
1dd2104
Compare
We are not using GitHub actions.
Don't force the coffee-rails library as dependencies of applications.