Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser #257

Closed
npc-allanb opened this issue Jun 10, 2021 · 1 comment
Closed

babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser #257

npc-allanb opened this issue Jun 10, 2021 · 1 comment
Labels
ATC Candidate Issues that are good candidates for ATC to pick up chore dependencies Pull requests that update a dependency file Package: eslint-plugin

Comments

@npc-allanb
Copy link

Overview

When installing @shopify/eslint-plugin a warning appears indicating that babel-eslint package is now deprecated in favour of @babel/eslint-parser

npm WARN deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.

Consuming repo

Package was installed from an embedded Shopify Node JS app.

Running Node version 16.3.0 and npm version 7.15.1

Expected behaviour

Installing @shopify/eslint-plugin runs without warnings.

Scope

  • Is this issue related to a specific package?

@shopify/eslint-plugin@40.2.3

@dahukish dahukish added ATC Candidate Issues that are good candidates for ATC to pick up chore dependencies Pull requests that update a dependency file Package: eslint-plugin labels Jun 11, 2021
@BPScott
Copy link
Member

BPScott commented Dec 13, 2021

Fixed in #305

@BPScott BPScott closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ATC Candidate Issues that are good candidates for ATC to pick up chore dependencies Pull requests that update a dependency file Package: eslint-plugin
Projects
None yet
Development

No branches or pull requests

3 participants