-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ESLint v8 #305
Support ESLint v8 #305
Conversation
- Replace babel-eslint with @babel/eslint-parser - Replace eslin-plugin-babel with @babel/eslint-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like a few dedupe opportunities in the lock file, but all the code makes sense.
yarn.lock
Outdated
@@ -2582,6 +2592,11 @@ acorn@^8.2.4: | |||
resolved "https://registry.yarnpkg.com/acorn/-/acorn-8.4.1.tgz#56c36251fc7cabc7096adc18f05afe814321a28c" | |||
integrity sha512-asabaBSkEKosYKMITunzX177CXxQ4Q8BSSzMTKD+FefUhipQC70gfW5SiUDhYQ3vk8G+81HqQk7Fv9OXwwn9KA== | |||
|
|||
acorn@^8.6.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Hey @BPScott - is there a possibility of a new release, so we can start using this? 🙏 |
Description
Fixes #300
Updates
@shopify/eslint-plugin
to support eslint v8.^7.30.0
to^8.3.0
babel-eslint
andeslint-plugin-babel
with@babel/eslint-parser
and@babel/eslint-plugin
.babel/*
rules to@babel/*
babel/camelcase
andbabel/valid-typeof
rules as they do not exist in@babel/eslint-plugin
.babel-eslint
to@babel/eslint-parser
ClassProperty
ast type to also check forPropertyDefinition
eslint-plugin-jest
andtypescript-eslint/*
andeslint-plugin-prettier
which caused the following changes:jest/prefer-inline-snapshots
rulejest/prefer-to-be-null
andjest/prefer-to-be-undefined
andjest/no-expect-resolves
rules withjest/prefer-to-be
andjest/no-restricted-matchers
jest/valid-describe
rule tojest/valid-describe-callback
jest/lowercase-name
rule tojest/prefer-lowercase-title
typescript-eslint/eslint-plugin
^4.28.2
^5.4.0
typescript-eslint/parser
^4.28.2
^5.4.0
eslint-plugin-import
^2.23.4
^2.25.3
eslint-plugin-jest
^24.3.6
^25.3.0
eslint-plugin-jest-formatting
^3.0.0
^3.1.0
eslint-plugin-jsx-a11y
^6.4.1
^6.5.0
eslint-plugin-prettier
^3.4.0
^4.0.0
eslint-plugin-promise
^5.1.0
^5.1.1
eslint-plugin-react
^7.24.0
^7.27.1
eslint-plugin-react-hooks
^4.2.0
^4.3.0
eslint-plugin-sort-class-members
^1.11.0
^1.14.0
Type of change