Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint-plugin-prettier to support prettier v3 #392

Closed
2 tasks done
andyvanee opened this issue Jul 12, 2023 · 2 comments
Closed
2 tasks done

Upgrade eslint-plugin-prettier to support prettier v3 #392

andyvanee opened this issue Jul 12, 2023 · 2 comments
Labels
bug Package: eslint-plugin

Comments

@andyvanee
Copy link

andyvanee commented Jul 12, 2023 •
edited
Loading

Overview

Prettier 3.0.0 has been released. In our app, the only significant change was needing to upgrade to eslint-plugin-prettier@^5.0.0 (which comes via @shopify/eslint-plugin)

Consuming repo

  • See backlink below

Checklist

  • Please delete the labels section before submitting your issue
  • I have described this issue in a way that is actionable (if possible)
@isaacbowen
Copy link

Very grateful y'all have these repos open. This issue helped unblock something important for us. :) Cheers!

gnarea added a commit to relaycorp/eslint-config that referenced this issue Jul 30, 2023
@gnarea
fix(deps): Force @shopify/eslint-plugin to use v5 of eslint-plugin-pr…
b12a40b 
…ettier

To work around Shopify/web-configs#392
gnarea added a commit to relaycorp/eslint-config that referenced this issue Jul 30, 2023
@gnarea
fix(deps): Properly force @shopify/eslint-plugin to use v5 of eslint-…
a7da956 
…plugin-prettier

To work around Shopify/web-configs#392
@andyvanee
Copy link
Author

Closed by #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Package: eslint-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyvanee @isaacbowen