Prefer buildClientSchema to buildSchema #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyfer
force-pushed
the
prefer-build-client-schema
branch
from
49a9f31
to
e0c7e0a
Compare
keyfer
changed the title
jtsmills
approved these changes
Aug 26, 2020
| function report(node) { | ||
| context.report({ | ||
| node, | ||
| message: `Prefer buildClientSchema to buildSchema`, |
There was a problem hiding this comment.
I wonder if we could even apply the fix here?
https://eslint.org/docs/developer-guide/working-with-rules#applying-fixes-1
There was a problem hiding this comment.
I was thinking about this, but due to not knowing how buildSchema could be used, and the differences in implementation, applying a standardized fix across x number of repos, with x implementations could get weird.
|
Looks like new Rails apps generated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new rule,
@shopify/typescript/prefer-build-client-schema, which flags uses ofbuildSchemaand recommends usingbuildClientSchemainstead due to our findings in performance.For more information on the performance findings, check here.