Fix the all.js test for the eslint-plugin #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atesgoral
approved these changes
Feb 11, 2021
dahukish
reviewed
Feb 11, 2021
| @@ -1,5 +1,6 @@ | |||
| query LintErrorFooQuery { | |||
| query AllTestQuery { | |||
dahukish
reviewed
Feb 11, 2021
| `--config ${fixtureFile('all/.eslintrc.js')} ${fixtureFile('all')}`, | ||
| `--ext .js,.graphql --ignore-pattern "**/all/build/*" --config ${fixtureFile( | ||
| 'all/.eslintrc.js', | ||
| )} ${fixtureFile('all')}`, | ||
| ), | ||
| ).toBe(''); | ||
| }, 8000); |
There was a problem hiding this comment.
do we worry this timeout mike make our tests flaky at some point?
There was a problem hiding this comment.
I didn't add it but I assume it was expanded to stop it from being flakey in CI environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
all.jstest works because it ignored the.graphqlfiles included in the fixture and didn't apply the.graphqlrules.This PR updates the fixture and the
all.test.jsexecution to include the graphql files.Type of change
@shopify/eslint-pluginPatch: Bug (non-breaking change which fixes an issue)Checklist