Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eslint] Adding in jsx-a11y/autocomplete-valid rule to config #218

Merged
merged 1 commit into from
Mar 11, 2021
Merged

[Eslint] Adding in jsx-a11y/autocomplete-valid rule to config #218

merged 1 commit into from
Mar 11, 2021

Conversation

gcornhill
Copy link
Contributor

@gcornhill gcornhill commented Mar 10, 2021 •
edited
Loading

Description

Adds jsx-a11y/autocomplete-valid rule to eslint config as part of Autocomplete Project.

Specifies 2 custom Polaris input types: TextField, Select

Resolves issues/217

Type of change

  • eslint-plugin Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

@gcornhill gcornhill self-assigned this Mar 10, 2021
@gcornhill gcornhill force-pushed the eslint-jsx-a11y-autocomplete branch from 56e4161 to bf284f5 Compare March 10, 2021 18:51
@gcornhill gcornhill force-pushed the eslint-jsx-a11y-autocomplete branch from bf284f5 to 4ebbceb Compare March 10, 2021 18:53
@atesgoral atesgoral requested a review from a team March 10, 2021 19:24
BPScott
BPScott approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

dahukish
dahukish approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@dahukish dahukish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gcornhill gcornhill merged commit 9b6d054 into main Mar 11, 2021
@gcornhill gcornhill deleted the eslint-jsx-a11y-autocomplete branch March 11, 2021 15:44
@shopify-shipit shopify-shipit bot deployed to production-common April 14, 2021 17:21 Active
@shopify-shipit shopify-shipit bot temporarily deployed to production April 16, 2021 17:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atesgoral atesgoral atesgoral approved these changes

@BPScott BPScott BPScott approved these changes

@dahukish dahukish dahukish approved these changes

Assignees

@gcornhill gcornhill

Labels
enhancement Package: eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add autocomplete linting config
4 participants
@gcornhill @atesgoral @BPScott @dahukish