Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a conflict between Prettier and rules */object-curly-spacing #227

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Fix a conflict between Prettier and rules */object-curly-spacing #227

merged 2 commits into from
Apr 16, 2021

Conversation

andreavaccari
Copy link
Contributor

Description

This PR fixes a rule conflict between Prettier and @typescript-eslint/object-curly-spacing and babel/object-curly-spacing.

Closes #226

Type of change

  • @shopify/eslint-plugin Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

@ghost ghost added the cla-needed label Apr 8, 2021
@andreavaccari
Copy link
Contributor Author

I signed the CLA. How do I rerun the check?

@ghost ghost removed the cla-needed label Apr 8, 2021
@atesgoral
Copy link
Contributor

atesgoral commented Apr 16, 2021 •
edited
Loading

@andreavaccari The CLA check has passed. Now the CI is failing... The CI passed as well. Thanks for this patch!

@atesgoral atesgoral requested a review from a team April 16, 2021 16:18
michenly
michenly approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@michenly michenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely ran into this before 👍
we will need to get this to sewing-kit before the rules get apply everywhere.

@atesgoral atesgoral merged commit a462a54 into Shopify:main Apr 16, 2021
@shopify-shipit shopify-shipit bot temporarily deployed to production April 16, 2021 17:21 Inactive
@shopify-shipit shopify-shipit bot deployed to production-common April 16, 2021 18:03 Active
@shopify-shipit shopify-shipit bot deployed to fix-loose-issue August 18, 2021 00:44 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michenly michenly michenly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prettier conflicts with */object-curly-spacing rules
3 participants
@andreavaccari @atesgoral @michenly