@shopify/eslint-plugin: merge typescript naming convention rules

[brendanrygus]

Description

While upgrading to v40.2.2, we noticed some changes in the @typescript-eslint/naming-convention rule.
Some of the recent changes around enforcing T prefixes for generic types might have loosened up other checks.

These previously invalid declarations all became valid in ts/tsx files:

type myCamelCasedType = 'ok'
const my_snake_cased_var = 'ok, ruby'
const object = {
  my_backend_enum_key: 'yup cool',
  MY_SCREAMING_KEYS: 'whatever'
}

Type of change

This PR merges the two @typescript-eslint/naming-convention rules together to restore the previous config.

• @shopify/eslint-plugin Patch: Bug (non-breaking change which fixes an issue)

Checklist

• I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

[brendanrygus]

I used the --print-config CLI arg to log out the eslint rules our repo used before the recent changes

I confirmed that the rules for typescript-eslint/naming-convention matched those in this file, so merging the two rule sets together seems like our best bet

    "@typescript-eslint/naming-convention": [
      "error",
      {
        "selector": "default",
        "format": [
          "camelCase",
          "PascalCase",
          "UPPER_CASE"
        ],
        "leadingUnderscore": "allow",
        "trailingUnderscore": "allow"
      },
      {
        "selector": "default",
        "filter": {
          "match": true,
          "regex": "^(__|UNSAFE_).+$"
        },
        "format": null
      },
      {
        "selector": "typeLike",
        "format": [
          "PascalCase"
        ]
      }
    ],

[dahukish]

Makes sense to me.

[dahukish]

This makes sense. Seems like the old rule was being overwritten hence the revert on what was valid. No 🎩 yet.

[brendanrygus]

Thanks @vsumner !

[brendanrygus]

Tophatting against my local app, and it looks like eslint has Strong Opinions again 😄