Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen eslint versions #297

Merged
merged 18 commits into from
Oct 22, 2021
Merged

Loosen eslint versions #297

merged 18 commits into from
Oct 22, 2021

Conversation

dahukish
Copy link
Contributor

@dahukish dahukish commented Oct 22, 2021

Description

Fixes: #295

This PR:

  • adds ^ to each of the eslint plugins to reduce version conflicts when used with other libraries with less strict semver patterns.

Note:
I did try to go full bore on updating to the latest versions but as some of the plugin have had major versions bumps that should come in follow up PRs.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • eslint-plugin Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

@dahukish dahukish self-assigned this Oct 22, 2021
yarn.lock Outdated Show resolved Hide resolved
@shopify-shipit shopify-shipit bot temporarily deployed to loosen-eslint-versions October 22, 2021 19:12 Inactive
Copy link
Contributor

@vsumner vsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@dahukish dahukish merged commit 84c180f into main Oct 22, 2021
@dahukish dahukish deleted the loosen-eslint-versions branch October 22, 2021 20:40
@shopify-shipit shopify-shipit bot temporarily deployed to production November 18, 2021 15:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eslint-plugin] Relax semver constraints
3 participants