Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js 16 support and update stylelint-plugin deps #298

Merged
merged 5 commits into from
Nov 2, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@ jobs:
test:
name: 'Test'
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['12.x', '14.x', '16.x']
steps:
- uses: actions/checkout@v2

- uses: actions/setup-node@v2
name: Use Node.js ${{ matrix.node-version }}
with:
node-version: '12.14.0'
node-version: ${{ matrix.node-version }}
cache: 'yarn'

- run: yarn --frozen-lockfile
Expand Down
5 changes: 2 additions & 3 deletions dev.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
name: web-configs
up:
- node:
version: v12.14.0
yarn: v1.22.5
version: 16.13.0
yarn: 1.22.15
commands:
__default__: start
check: yarnpkg check
lint: yarnpkg lint
start: echo "Running web-configs is not really a concept that makes sense."
test: yarnpkg test
generate: yarnpkg generate

10 changes: 5 additions & 5 deletions packages/stylelint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@
"homepage": "https://github.com/Shopify/web-configs/blob/main/packages/stylelint-plugin/README.md",
"dependencies": {
"merge": "^2.1.1",
"stylelint-config-prettier": "^8.0.1",
"stylelint-order": "^4.0.0",
"stylelint-config-prettier": "^9.0.3",
"stylelint-order": "^5.0.0",
"stylelint-prettier": "^1.2.0",
"stylelint-scss": "^3.19.0"
"stylelint-scss": "^4.0.0"
},
"devDependencies": {
"stylelint": "^13.12.0"
"stylelint": "^14.0.1"
},
"peerDependencies": {
"stylelint": ">=13.12.0"
"stylelint": ">=14.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

}
}
4 changes: 2 additions & 2 deletions packages/stylelint-plugin/tests/utilities.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function testRule(rule, schema) {
const options = {
code: testCase.code,
config: stylelintConfig,
syntax: schema.syntax,
customSyntax: schema.syntax,
codeFilename: schema.codeFilename,
};

Expand Down Expand Up @@ -69,7 +69,7 @@ export function testRule(rule, schema) {
const options = {
code: testCase.code,
config: stylelintConfig,
syntax: schema.syntax,
customSyntax: schema.syntax,
codeFilename: schema.codeFilename,
};

Expand Down
Loading