Update CI to tests multiple node versions, use node 16 locally #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atesgoral
approved these changes
Nov 26, 2021
|
Updated the branch protection rules so now they require the three new test checks ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node versions we test against in CI are: 12.14 - our lowest target for packages, and 14.x and 16.x - whatever the latest releases for these branches are - this matches what quilt does.
Locally we run against 16.13 - the first LTS release in the v16 line.
We attempted part of this previously, but bundled it with a bunch of stylelint updates that needed to be reverted in #298