Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add q as allowed identifier in eslint #329

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Conversation

ianks
Copy link
Contributor

@ianks ianks commented Mar 29, 2022

Description

q is a common identifier for a search query param, and it used in many apps across Shopify.

Previously, we had to do this:

// eslint-disable-next-line
const { data, loading, error } = useSearchPackages({ q: "foo" })

This patch makes it less painful to use q in Javascript-land.

Type of change

  • @shopify/eslint-plugin Patch: Bug (non-breaking change which fixes an issue)
  • @shopify/eslint-plugin Minor: New feature (non-breaking change which adds functionality)
  • @shopify/eslint-plugin Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

`q` is a common identifier for a search query param, and it used in many apps across Shopify. This patch allows its usage.
@ianks ianks requested a review from BPScott March 29, 2022 21:32
@ianks
Copy link
Contributor Author

ianks commented Mar 30, 2022

Couldn't figure out the changelog test... but here's what I was going to add if it helps:

### Changed

- Allow usage of `q` variable in `id-length` rule [[#329](https://github.com/Shopify/web-configs/pull/329)]

@ianks ianks removed the request for review from BPScott March 30, 2022 21:25
@BPScott
Copy link
Member

BPScott commented Apr 3, 2022

@ianks Regarding the changelog - uncomment the ## Unreleased header, in addition to adding the content in your comment

Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of pushing up the correction to the chnagelog.

Thanks!

@BPScott BPScott merged commit 1f770be into Shopify:main Apr 4, 2022
@BPScott
Copy link
Member

BPScott commented Apr 4, 2022

Published as 41.2.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants