Flatten eslint configs, removing config/rules #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The config definitions in
lib/configs
, import contents fromlib/configs/rules
. This extra layer of indirection adds no value - nothing is ever reused.This PR flattens this indirection, replacing
require
calls inlib/configs/*.js
with the contents of the files being required.This has no affect on the rulesets used, it's just tidying.
To test
Compare the evaluated output of the
lib/config/*.js
files on main, and in this branch and note that they are identical.Copy the following script into the root of the repo as
test.js
:node test.js > main-config-content.md
node test.js > branch-config-content.md
diff -u main-config-content.md branch-config-content.md
Note that modifying some file in lib/config and doing the above again shall result in some diff output to prove that changes are noticed.