Don't replace top/right/bottom/left declarations with inset #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inset is only supported in iOS Safari 14.5+, which we can still potentially support
joswong13-shopify
approved these changes
Mar 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable the autofix added in Stylelint 15.3 that replaces
top/right/bottom/leftdefinitions withinset, asinsetis only supported in iOS Safari 14.5+, which we still potentially support.This is an example of the autofix behaviour that we want to disable:
a { - top: 1; - right: 2; - bottom: 3; - left: 4; + inset: 1 2 3 4; }